-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Define new JF server variables for JF Admins only #39095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #39095: Size comparison from b996746 to f5f14f9 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #39095: Size comparison from 08eb175 to f6ec315 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
May 21, 2025
e0e019a
to
0def7e7
Compare
PR #39095: Size comparison from 05e766b to 0def7e7 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
doru91
reviewed
May 27, 2025
doru91
approved these changes
May 28, 2025
andy31415
approved these changes
May 28, 2025
andy31415
reviewed
May 28, 2025
98059d5
to
adae356
Compare
PR #39095: Size comparison from d856945 to f73efc1 Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, nxp, psoc6, qpg, stm32)
|
PR #39095: Size comparison from 68fb9b5 to 662a3d3 Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, nxp, psoc6, qpg, stm32)
|
PR #39095: Size comparison from e3f1635 to d59f5fc Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #39095: Size comparison from 0a18b85 to bbc190b Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
documentation
Improvements or additions to documentation
examples
lib
platform
review - approved
tools
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new server variables introduced in PR #38842 are only needed for JF admins and should not be exposed to all devices.
Addresses #39093
Testing
Verify if the server variables are available only if for JF Admins